From 26b593b1eac483f700c72b4195e372f4b92acc7f Mon Sep 17 00:00:00 2001 From: dec05eba Date: Fri, 11 Jun 2021 07:36:13 +0200 Subject: Do not auto pause for seconds when buffering --- TODO | 3 ++- src/VideoPlayer.cpp | 1 + src/plugins/Youtube.cpp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 4a23870..2f033e5 100644 --- a/TODO +++ b/TODO @@ -162,4 +162,5 @@ Add loading of english subtitles for youtube. Cancel search when new search happens. Update item height when it switches from not being merged with previous to being merged with previous. This happens when loading previous messages in matrix and the message is the top one. Reload youtube video url if the video is idle for too long. The video url is only valid for a specific amount of time (the valid duration is in the json). -Improve live stream startup time by downloading the video formats in parts instead of the hls manifest? \ No newline at end of file +Improve live stream startup time by downloading the video formats in parts instead of the hls manifest? +Add youtube chapters. \ No newline at end of file diff --git a/src/VideoPlayer.cpp b/src/VideoPlayer.cpp index 4fce4e0..adc7eb8 100644 --- a/src/VideoPlayer.cpp +++ b/src/VideoPlayer.cpp @@ -134,6 +134,7 @@ namespace QuickMedia { ytdl_format.c_str(), // TODO: Disable hr seek on low power devices? "--hr-seek=yes", + "--cache-pause=no", "--cookies", cookies_file_arg.c_str(), input_conf.c_str(), diff --git a/src/plugins/Youtube.cpp b/src/plugins/Youtube.cpp index 8575d07..ce359d4 100644 --- a/src/plugins/Youtube.cpp +++ b/src/plugins/Youtube.cpp @@ -1904,7 +1904,7 @@ namespace QuickMedia { if(!streaming_data_json.isObject()) return PluginResult::ERR; - // TODO: Verify if this always works (what about copyrighted live streams?), also what about choosing video quality for live stream? + // TODO: Verify if this always works (what about copyrighted live streams?), also what about choosing video quality for live stream? Maybe use mpv --hls-bitrate option? const Json::Value &hls_manifest_url_json = streaming_data_json["hlsManifestUrl"]; if(hls_manifest_url_json.isString()) { hls_manifest_url = hls_manifest_url_json.asString(); -- cgit v1.2.3