From 2b7d5d54011ffcc93511bf05f44163a4b7a1270c Mon Sep 17 00:00:00 2001 From: Tulir Asokan Date: Sun, 16 Jun 2019 14:29:03 +0300 Subject: Fix reply rendering infinite loop bug --- ui/messages/base.go | 4 +++- ui/messages/parser.go | 4 +--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'ui/messages') diff --git a/ui/messages/base.go b/ui/messages/base.go index 123c5c1..ef495fb 100644 --- a/ui/messages/base.go +++ b/ui/messages/base.go @@ -241,6 +241,7 @@ func (msg *UIMessage) Draw(screen mauview.Screen) { func (msg *UIMessage) Clone() *UIMessage { clone := *msg + clone.ReplyTo = nil clone.Renderer = clone.Renderer.Clone() return &clone } @@ -253,7 +254,8 @@ func (msg *UIMessage) CalculateReplyBuffer(preferences config.UserPreferences, w } func (msg *UIMessage) CalculateBuffer(preferences config.UserPreferences, width int) { - msg.Renderer.CalculateBuffer(preferences, width-1, msg) + msg.Renderer.CalculateBuffer(preferences, width, msg) + msg.CalculateReplyBuffer(preferences, width) } func (msg *UIMessage) DrawReply(screen mauview.Screen) mauview.Screen { diff --git a/ui/messages/parser.go b/ui/messages/parser.go index 123f323..29f078c 100644 --- a/ui/messages/parser.go +++ b/ui/messages/parser.go @@ -49,9 +49,7 @@ func ParseEvent(matrix ifc.MatrixContainer, mainView ifc.MainView, room *rooms.R } if len(evt.Content.GetReplyTo()) > 0 { if replyToMsg := getCachedEvent(mainView, room.ID, evt.Content.GetReplyTo()); replyToMsg != nil { - replyToMsg = replyToMsg.Clone() - replyToMsg.ReplyTo = nil - msg.ReplyTo = replyToMsg + msg.ReplyTo = replyToMsg.Clone() } else if replyToEvt, _ := matrix.GetEvent(room, evt.Content.GetReplyTo()); replyToEvt != nil { if replyToMsg := directParseEvent(matrix, room, replyToEvt); replyToMsg != nil { msg.ReplyTo = replyToMsg -- cgit v1.2.3