From bc41f075e03b29107a0919c3292feb04a1d1e879 Mon Sep 17 00:00:00 2001 From: dec05eba Date: Fri, 28 Aug 2020 19:56:12 +0200 Subject: Add option to record without audio input --- README.md | 3 +++ src/main.cpp | 25 +++++++++++++++---------- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 2dc6355..1489d48 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,7 @@ gtk frontend for [gpu-screen-recorder](https://git.dec05eba.com/gpu-screen-recorder/). The gpu-screen-recorder needs to be installed to use this gtk frontend. +This screen recorder can be used for recording your desktop offline, for live streaming and for nvidia-like instant replay, +where only the last few seconds are saved. + # TODO Stop streaming/recording if the child process dies. This could happen when out of disk space, or when streaming network connection is lost diff --git a/src/main.cpp b/src/main.cpp index 687ed8d..2fd27d1 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -190,9 +190,6 @@ static gboolean on_start_recording_button_click(GtkButton *button, gpointer user int fps = gtk_spin_button_get_value_as_int(fps_entry); gchar* audio_input_str = gtk_combo_box_text_get_active_text(audio_input_menu); - if(!audio_input_str) { - fprintf(stderr, "No audio input selected!\n"); - } if(select_window_userdata.selected_window == None) { fprintf(stderr, "No window selected!\n"); @@ -227,8 +224,13 @@ static gboolean on_start_recording_button_click(GtkButton *button, gpointer user // Redirect stdout to output_file dup2(output_file, STDOUT_FILENO); - const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "mp4", "-f", fps_str.c_str(), "-a", audio_input_str, NULL }; - execvp(args[0], (char* const*)args); + if(audio_input_str && strcmp(audio_input_str, "None") != 0) { + const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "mp4", "-f", fps_str.c_str(), "-a", audio_input_str, NULL }; + execvp(args[0], (char* const*)args); + } else { + const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "mp4", "-f", fps_str.c_str(), NULL }; + execvp(args[0], (char* const*)args); + } perror("failed to launch gpu-screen-recorder"); } else { /* parent process */ gpu_screen_recorder_process = pid; @@ -304,9 +306,6 @@ static gboolean on_start_streaming_button_click(GtkButton *button, gpointer user int fps = gtk_spin_button_get_value_as_int(fps_entry); gchar* audio_input_str = gtk_combo_box_text_get_active_text(audio_input_menu); - if(!audio_input_str) { - fprintf(stderr, "No audio input selected!\n"); - } if(select_window_userdata.selected_window == None) { fprintf(stderr, "No window selected!\n"); @@ -341,8 +340,13 @@ static gboolean on_start_streaming_button_click(GtkButton *button, gpointer user // Redirect stdout to output_file dup2(pipe_write_end, STDOUT_FILENO); - const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "flv", "-f", fps_str.c_str(), "-a", audio_input_str, NULL }; - execvp(args[0], (char* const*)args); + if(audio_input_str && strcmp(audio_input_str, "None") != 0) { + const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "flv", "-f", fps_str.c_str(), "-a", audio_input_str, NULL }; + execvp(args[0], (char* const*)args); + } else { + const char *args[] = { "gpu-screen-recorder", "-w", window_str.c_str(), "-c", "flv", "-f", fps_str.c_str(), NULL }; + execvp(args[0], (char* const*)args); + } perror("failed to launch gpu-screen-recorder"); exit(127); } else { /* parent process */ @@ -465,6 +469,7 @@ static GtkWidget* create_common_settings_page(GtkStack *stack, GtkApplication *a gtk_grid_attach(grid, GTK_WIDGET(audio_grid), 0, 2, 2, 1); gtk_grid_attach(audio_grid, gtk_label_new("Audio input: "), 0, 0, 1, 1); audio_input_menu = GTK_COMBO_BOX_TEXT(gtk_combo_box_text_new()); + gtk_combo_box_text_append_text(audio_input_menu, "None"); populate_audio_input_menu_with_pulseaudio_monitors(); g_signal_connect(audio_input_menu, "changed", G_CALLBACK(audio_input_change_callback), nullptr); gtk_widget_set_hexpand(GTK_WIDGET(audio_input_menu), true); -- cgit v1.2.3