From 3a85b457c89e89dfc4db5f2a1e60666821c7abb8 Mon Sep 17 00:00:00 2001 From: dec05eba Date: Fri, 28 Jul 2023 23:06:26 +0200 Subject: Remove TODO items, improve readme replay service section --- README.md | 3 ++- TODO | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 6e9a46a..524080e 100644 --- a/README.md +++ b/README.md @@ -77,7 +77,8 @@ hotkey settings on your system and choose a hotkey to run the script `scripts/sa If you are running a distro that uses systemd then you can use the systemd service in `extra/gpu-screen-recorder.service` instead. Copy `extra/gpu-screen-recorder.service` to a location where systemd can find it, for example: `$HOME/.config/systemd/user` and then enable and start it with: `systemctl enable --now --user gpu-screen-recorder`. Copying the systemd service file is not needed if you installed GPU Screen Recorder from AUR as this is done automatically. You can then use the same `scripts/save-replay.sh` script to save a replay. The systemd service is configured with the file `$HOME/.config/gpu-screen-recorder.env` (create it if it doesn't exist). -You can see which variables that you can use by looking at the gpu-screen-recorder.service file. Restart the systemd service after modifying that configuration file. By default it saves videos in `$HOME/Videos`.\ +You can see which variables that you can use by looking at the gpu-screen-recorder.service file. In general you only need to set the `WINDOW` variable to make it work. +Restart the systemd service after modifying that configuration file. By default it saves videos in `$HOME/Videos`.\ If you are using a NVIDIA GPU then it's recommended to set PreserveVideoMemoryAllocations=1 as mentioned in the section below. ## Issues diff --git a/TODO b/TODO index 325f03c..0e5e619 100644 --- a/TODO +++ b/TODO @@ -9,7 +9,6 @@ Allow recording a region by recording the compositor proxy window / nvfbc window Use nvenc directly, which allows removing the use of cuda. Handle xrandr monitor change in nvfbc. Implement follow focused in drm. -Support fullscreen capture on amd/intel using external kms process. Support amf and qsv. Disable flipping on nvidia? this might fix some stuttering issues on some setups. See NvCtrlGetAttribute/NvCtrlSetAttributeAndGetStatus NV_CTRL_SYNC_TO_VBLANK https://github.com/NVIDIA/nvidia-settings/blob/d5f022976368cbceb2f20b838ddb0bf992f0cfb9/src/gtk%2B-2.x/ctkopengl.c. Replays seem to have some issues with audio/video. Why? @@ -55,8 +54,6 @@ Intel is a bit weird with monitor capture and multiple monitors. If one of the m Is that only the case when the primary monitor is rotated? Also the primary monitor becomes position 0, 0 so crtc (x11 randr) position doesn't match the drm pos. Maybe get monitor position and size from drm instead. How about if multiple monitors are rotated? -When using multiple monitors kms grab the target monitor instead of the whole screen. - Support vp8/vp9/av1. This is especially important on amd which on some distros (such as Manjaro) where hardware accelerated h264/hevc is disabled in the mesa package. Support screen (all monitors) capture on amd/intel when no combined plane is found. -- cgit v1.2.3