From be388cda5ff9e96078e39ff9c5f963e4b8fc451c Mon Sep 17 00:00:00 2001
From: dec05eba <dec05eba@protonmail.com>
Date: Sat, 8 Apr 2023 05:50:43 +0200
Subject: kms permission ok if running as root, no pkexec needed

---
 src/kms/kms_server.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src/kms/kms_server.c')

diff --git a/src/kms/kms_server.c b/src/kms/kms_server.c
index f811050..e7ee02f 100644
--- a/src/kms/kms_server.c
+++ b/src/kms/kms_server.c
@@ -73,6 +73,7 @@ static int get_kms(const char *card_path, gsr_kms_response *response) {
     if (0 != drmSetClientCap(drmfd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1)) {
         response->result = KMS_RESULT_INSUFFICIENT_PERMISSIONS;
         snprintf(response->data.err_msg, sizeof(response->data.err_msg), "drmSetClientCap failed, error: %s", strerror(errno));
+        close(drmfd);
         return -1;
     }
 
@@ -80,6 +81,7 @@ static int get_kms(const char *card_path, gsr_kms_response *response) {
     if (!planes) {
         response->result = KMS_RESULT_FAILED_TO_GET_KMS;
         snprintf(response->data.err_msg, sizeof(response->data.err_msg), "failed to access planes, error: %s", strerror(errno));
+        close(drmfd);
         return -1;
     }
 
@@ -134,7 +136,7 @@ static int get_kms(const char *card_path, gsr_kms_response *response) {
     }
 
     drmModeFreePlaneResources(planes);
-    close(drmfd); // TODO?
+    close(drmfd);
 
     if(response->data.fd.fd == 0) {
         response->result = KMS_RESULT_NO_KMS_AVAILABLE;
-- 
cgit v1.2.3