From fc4756ddf17f536912a89a4ffcf90a309c236ced Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Thu, 19 May 2016 07:53:07 +0100
Subject: Fix up some names, and protobuf tags

Make names (of session_key and message_index) more consistent.

Use our own protobuf tags rather than trying to piggyback on the one-to-one
structure.
---
 src/error.c                 |  2 ++
 src/inbound_group_session.c | 12 ++++++------
 src/message.cpp             | 26 ++++++++++++++------------
 3 files changed, 22 insertions(+), 18 deletions(-)

(limited to 'src')

diff --git a/src/error.c b/src/error.c
index 0690856..bd8a39d 100644
--- a/src/error.c
+++ b/src/error.c
@@ -27,6 +27,8 @@ static const char * ERRORS[] = {
     "BAD_ACCOUNT_KEY",
     "UNKNOWN_PICKLE_VERSION",
     "CORRUPTED_PICKLE",
+    "BAD_SESSION_KEY",
+    "UNKNOWN_MESSAGE_INDEX",
 };
 
 const char * _olm_error_to_string(enum OlmErrorCode error)
diff --git a/src/inbound_group_session.c b/src/inbound_group_session.c
index 34908a9..cc6ba5e 100644
--- a/src/inbound_group_session.c
+++ b/src/inbound_group_session.c
@@ -78,7 +78,7 @@ size_t olm_init_inbound_group_session(
     }
 
     if (raw_length != MEGOLM_RATCHET_LENGTH) {
-        session->last_error = OLM_BAD_RATCHET_KEY;
+        session->last_error = OLM_BAD_SESSION_KEY;
         return (size_t)-1;
     }
 
@@ -223,7 +223,7 @@ size_t olm_group_decrypt(
         return (size_t)-1;
     }
 
-    if (!decoded_results.has_chain_index || !decoded_results.session_id
+    if (!decoded_results.has_message_index || !decoded_results.session_id
         || !decoded_results.ciphertext
     ) {
         session->last_error = OLM_BAD_MESSAGE_FORMAT;
@@ -241,11 +241,11 @@ size_t olm_group_decrypt(
 
     /* pick a megolm instance to use. If we're at or beyond the latest ratchet
      * value, use that */
-    if ((int32_t)(decoded_results.chain_index - session->latest_ratchet.counter) >= 0) {
+    if ((int32_t)(decoded_results.message_index - session->latest_ratchet.counter) >= 0) {
         megolm = &session->latest_ratchet;
-    } else if ((int32_t)(decoded_results.chain_index - session->initial_ratchet.counter) < 0) {
+    } else if ((int32_t)(decoded_results.message_index - session->initial_ratchet.counter) < 0) {
         /* the counter is before our intial ratchet - we can't decode this. */
-        session->last_error = OLM_BAD_CHAIN_INDEX;
+        session->last_error = OLM_UNKNOWN_MESSAGE_INDEX;
         return (size_t)-1;
     } else {
         /* otherwise, start from the initial megolm. Take a copy so that we
@@ -254,7 +254,7 @@ size_t olm_group_decrypt(
         megolm = &tmp_megolm;
     }
 
-    megolm_advance_to(megolm, decoded_results.chain_index);
+    megolm_advance_to(megolm, decoded_results.message_index);
 
     /* now try checking the mac, and decrypting */
     r = cipher->ops->decrypt(
diff --git a/src/message.cpp b/src/message.cpp
index ec44262..ab4300e 100644
--- a/src/message.cpp
+++ b/src/message.cpp
@@ -328,17 +328,19 @@ void olm::decode_one_time_key_message(
 
 
 
-static std::uint8_t const GROUP_SESSION_ID_TAG = 052;
+static const std::uint8_t GROUP_SESSION_ID_TAG = 012;
+static const std::uint8_t GROUP_MESSAGE_INDEX_TAG = 020;
+static const std::uint8_t GROUP_CIPHERTEXT_TAG = 032;
 
 size_t _olm_encode_group_message_length(
     size_t group_session_id_length,
-    uint32_t chain_index,
+    uint32_t message_index,
     size_t ciphertext_length,
     size_t mac_length
 ) {
     size_t length = VERSION_LENGTH;
     length += 1 + varstring_length(group_session_id_length);
-    length += 1 + varint_length(chain_index);
+    length += 1 + varint_length(message_index);
     length += 1 + varstring_length(ciphertext_length);
     length += mac_length;
     return length;
@@ -349,7 +351,7 @@ void _olm_encode_group_message(
     uint8_t version,
     const uint8_t *session_id,
     size_t session_id_length,
-    uint32_t chain_index,
+    uint32_t message_index,
     size_t ciphertext_length,
     uint8_t *output,
     uint8_t **ciphertext_ptr
@@ -360,8 +362,8 @@ void _olm_encode_group_message(
     *(pos++) = version;
     pos = encode(pos, GROUP_SESSION_ID_TAG, session_id_pos, session_id_length);
     std::memcpy(session_id_pos, session_id, session_id_length);
-    pos = encode(pos, COUNTER_TAG, chain_index);
-    pos = encode(pos, CIPHERTEXT_TAG, *ciphertext_ptr, ciphertext_length);
+    pos = encode(pos, GROUP_MESSAGE_INDEX_TAG, message_index);
+    pos = encode(pos, GROUP_CIPHERTEXT_TAG, *ciphertext_ptr, ciphertext_length);
 }
 
 void _olm_decode_group_message(
@@ -375,8 +377,8 @@ void _olm_decode_group_message(
 
     results->session_id = nullptr;
     results->session_id_length = 0;
-    bool has_chain_index = false;
-    results->chain_index = 0;
+    bool has_message_index = false;
+    results->message_index = 0;
     results->ciphertext = nullptr;
     results->ciphertext_length = 0;
 
@@ -390,11 +392,11 @@ void _olm_decode_group_message(
             results->session_id, results->session_id_length
         );
         pos = decode(
-            pos, end, COUNTER_TAG,
-            results->chain_index, has_chain_index
+            pos, end, GROUP_MESSAGE_INDEX_TAG,
+            results->message_index, has_message_index
         );
         pos = decode(
-            pos, end, CIPHERTEXT_TAG,
+            pos, end, GROUP_CIPHERTEXT_TAG,
             results->ciphertext, results->ciphertext_length
         );
         if (unknown == pos) {
@@ -403,5 +405,5 @@ void _olm_decode_group_message(
         unknown = pos;
     }
 
-    results->has_chain_index = (int)has_chain_index;
+    results->has_message_index = (int)has_message_index;
 }
-- 
cgit v1.2.3