From 88effd4a0d63e37a2851712f63a9709a1e322946 Mon Sep 17 00:00:00 2001 From: dec05eba Date: Mon, 1 Oct 2018 15:01:39 +0200 Subject: Fix sibs not finding test code in subdirs of test dir Fix platform specific configs, not all configs were checked --- backend/BackendUtils.cpp | 2 +- backend/ninja/Ninja.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'backend') diff --git a/backend/BackendUtils.cpp b/backend/BackendUtils.cpp index 4e1a0e8..92a73ef 100644 --- a/backend/BackendUtils.cpp +++ b/backend/BackendUtils.cpp @@ -104,7 +104,7 @@ namespace backend projectConfPath += TINYDIR_STRING("project.conf"); auto projectConfFileType = getFileType(projectConfPath.c_str()); - if(projectConfFileType == FileType::REGULAR) + if(!sibsConfig.isTest() && getFileType(projectConfPath.c_str()) == FileType::REGULAR) { backend::Ninja *subProject = new backend::Ninja(); diff --git a/backend/ninja/Ninja.cpp b/backend/ninja/Ninja.cpp index 0c9cf0e..666bba7 100644 --- a/backend/ninja/Ninja.cpp +++ b/backend/ninja/Ninja.cpp @@ -1485,7 +1485,7 @@ namespace backend bool zigTest = false; if(config.zigTestAllFiles) { - backend::BackendUtils::collectSourceFiles(testSourceDirNative.c_str(), &ninja, sibsTestConfig, false); + backend::BackendUtils::collectSourceFiles(testSourceDirNative.c_str(), &ninja, sibsTestConfig); // TODO: This can be optimized as well. No need to insert non-zig files if we are going to remove them. // Maybe pass a filter callback function to @collectSourceFiles. for(auto it = ninja.sourceFiles.begin(); it != ninja.sourceFiles.end(); ) @@ -1512,7 +1512,7 @@ namespace backend } else { - backend::BackendUtils::collectSourceFiles(testSourceDirNative.c_str(), &ninja, sibsTestConfig, false); + backend::BackendUtils::collectSourceFiles(testSourceDirNative.c_str(), &ninja, sibsTestConfig); } if(!ninja.getSourceFiles().empty()) -- cgit v1.2.3