Fix uninitialized read of unfinished torrents

3 files changed, 5 insertions, 2 deletions

diff --git a/README.md b/README.md
index e3b8ef9..e7ce86b 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@ Run automedia without any options to see all options.
 4. Convert python plugins to C.
 # Requirements
 ## System
-transmission-cli, notify-send (optional)
+curl, transmission-cli, notify-send (optional)
 ## Python
 lxml, requests, pure_protobuf (optional, used with mangaplus.shueisha.co.jp)
 # Requirements when using read_manga.py
diff --git a/automedia b/automedia
index 84d41c7..5d7814e 100755
--- a/automedia
+++ b/automedia
diff --git a/src/main.c b/src/main.c
index 10ba396..b2f238a 100644
--- a/src/main.c
+++ b/src/main.c
@@ -409,8 +409,10 @@ static void torrent_list_check_new_downloads_callback(int id, const char *name,
         }
     } else {
         if(id >= unfinished_torrents->size) {
+            int prev_size = unfinished_torrents->size;
             unfinished_torrents->size = id + 128;
             unfinished_torrents->items = realloc_or_crash(unfinished_torrents->items, unfinished_torrents->size);
+            memset(unfinished_torrents->items + prev_size, 0, unfinished_torrents->size - prev_size);
         }
         unfinished_torrents->items[id] = 1;
     }
@@ -434,8 +436,9 @@ static void sync_rss_html(char *rss_config_dir, char *html_config_dir, char *pro
     int check_torrent_status_rate_sec = 15;
 
     UnfinishedTorrents unfinished_torrents;
-    unfinished_torrents.items = alloc_or_crash(1024);
     unfinished_torrents.size = 1024;
+    unfinished_torrents.items = alloc_or_crash(unfinished_torrents.size);
+    memset(unfinished_torrents.items, 0, unfinished_torrents.size);
 
     automedia_running = 1;
     /* running is set to 0 in SIGINT signal handler (ctrl+c) */