aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordec05eba <dec05eba@protonmail.com>2019-02-20 18:42:41 +0100
committerdec05eba <dec05eba@protonmail.com>2020-07-06 07:39:33 +0200
commitce78a25ca562b44c2ff331d0ca3b6eef373fe569 (patch)
treea0ddb0e80b240a51f967f180635c77a53fc5f703
parent3b99b3a9f02af061f06a21e26f279b2ae2790810 (diff)
Temporary remove compdb check. Is compdb really needed?
-rw-r--r--README.md2
-rw-r--r--backend/ninja/Ninja.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/README.md b/README.md
index 35677d4..d22c209 100644
--- a/README.md
+++ b/README.md
@@ -57,7 +57,7 @@ You can run `scripts/mingw_package.py` to automatically copy dynamic library dep
Manual cross compilation can be done by replacing c, c++ compilers and linker (ar) using the environment variable CC, CXX and AR.
# IDE support
-Sibs generates a compile_commands.json in the project root directory when executing `sibs build` and tools that support clang completion can be used, such as YouCompleteMe or cquery. To generate compile_commands.json that also finds header files (non-relative) you need to have compdb installed and available in your PATH environment variable: https://github.com/Sarcasm/compdb
+Sibs generates a compile_commands.json in the project root directory when executing `sibs build` and tools that support clang completion can be used, such as YouCompleteMe or cquery.
There are several editors that support YouCompleteMe, including Vim, Emacs and Visual Studio Code. Visual studio code now also supports clang completion with C/C++ extension by Microsoft. I recommend using Visual Studio Code along with cquery (https://github.com/cquery-project/cquery/wiki), which gives you very good IDE support for your C/C++ projects:
![Image of cquery extension in Visual Studio Code](preview.png)
If you are using Visual Studio Code then you should add .vscode/ to .gitignore or Visual Studio Code will lag a lot (because cquery adds a lot of files in .vscode directory).
diff --git a/backend/ninja/Ninja.cpp b/backend/ninja/Ninja.cpp
index 5d1a506..1dc15e2 100644
--- a/backend/ninja/Ninja.cpp
+++ b/backend/ninja/Ninja.cpp
@@ -1849,7 +1849,7 @@ namespace backend
Result<bool> Ninja::buildCompilationDatabase(const _tinydir_char_t *buildFilePath, const FileString &saveDir)
{
Result<ExecResult> compdbAvailableResult = exec(TINYDIR_STRING("compdb version"), false);
- bool isCompdbAvailable = (compdbAvailableResult && compdbAvailableResult.unwrap().exitCode == 0);
+ bool isCompdbAvailable = false;//(compdbAvailableResult && compdbAvailableResult.unwrap().exitCode == 0);
FileString command = TINYDIR_STRING("ninja -C \"");
command += buildFilePath;