aboutsummaryrefslogtreecommitdiff
path: root/backend/ninja/Ninja.cpp
diff options
context:
space:
mode:
authordec05eba <dec05eba@protonmail.com>2017-12-28 01:02:16 +0100
committerdec05eba <dec05eba@protonmail.com>2017-12-28 01:27:11 +0100
commit0cf81a4421f9a4d267245a3041508b617a01d68d (patch)
tree1eb816c05cc005abe317439516ba6b06c4dfbdfb /backend/ninja/Ninja.cpp
parent5100c0659e39dd82a3b979b859704e7dbf01e2f1 (diff)
Add curl get, add packages file
Diffstat (limited to 'backend/ninja/Ninja.cpp')
-rw-r--r--backend/ninja/Ninja.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/backend/ninja/Ninja.cpp b/backend/ninja/Ninja.cpp
index 59b0a3a..e290436 100644
--- a/backend/ninja/Ninja.cpp
+++ b/backend/ninja/Ninja.cpp
@@ -174,6 +174,9 @@ namespace backend
printf("Dependency not found in global lib, trying to download from github\n");
// TODO: Download several dependencies at the same time by adding them to a list
// and then iterate them and download them all using several threads.
+ // All dependecies should be downloaded at the same time, this includes dependencies of dependencies.
+ // If a dependency is missing, fail build BEFORE downloading dependencies and before compiling anything.
+ // You do not want to possibly wait several minutes only for build to fail when there is no compilation error.
// TODO: If return error is invalid url, then the message should be converted to
// invalid package name/version. A check should be done if it is the name or version