aboutsummaryrefslogtreecommitdiff
path: root/backend
diff options
context:
space:
mode:
authordec05eba <dec05eba@protonmail.com>2018-01-19 23:18:25 +0100
committerdec05eba <dec05eba@protonmail.com>2018-01-26 09:13:15 +0100
commit76a5e558e100d40fdf7177cf3e1ab982faa06b2b (patch)
tree1d192b112883f69758c3fcaf45b7556ff920ffa5 /backend
parentbf2527a301d6048816958f92129289258ba5991d (diff)
Add todo
Diffstat (limited to 'backend')
-rw-r--r--backend/ninja/Ninja.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/backend/ninja/Ninja.cpp b/backend/ninja/Ninja.cpp
index 06345d9..6104d52 100644
--- a/backend/ninja/Ninja.cpp
+++ b/backend/ninja/Ninja.cpp
@@ -856,6 +856,9 @@ namespace backend
return buildResult;
}
+ // TODO: If tests are being run (sibs test) and root project is an executable, do not run compile (above code) as executable.
+ // Sibs test will compile root project as dynamic library so you end up compiling the project twice, first as an executable and then as a dynamic library.
+ // Even if the root project has been built before and there is cached object, it will take a few seconds to run compile
Result<bool> buildTestResult = buildTests(projectGeneratedBinary, config, savePath, dependencyExportIncludeDirs);
if(!buildTestResult)
return buildTestResult;
@@ -863,6 +866,7 @@ namespace backend
return Result<bool>::Ok(true);
}
+ // TODO: Add "c++" file extension, seems to be used in some places?
const _tinydir_char_t *sourceFileExtensions[] = { TINYDIR_STRING("c"), TINYDIR_STRING("cc"), TINYDIR_STRING("cpp"), TINYDIR_STRING("cxx") };
bool isSourceFile(tinydir_file *file)
{