aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordec05eba <dec05eba@protonmail.com>2025-05-03 19:28:25 +0200
committerdec05eba <dec05eba@protonmail.com>2025-05-03 19:29:04 +0200
commit0cdc3599318f05a820b3c936f83c98b4b3d11567 (patch)
treef3618bb6c424f645e97606e0f68e34b2a9ded27b
parent39bc110a2015f9dba8ee707ecd2c9c2901d8c2ff (diff)
Fix audio capture not working with noisetorch if combined with another source with some audio devices. Remove the ability to set audio track name for now. If you need this, email me
-rw-r--r--TODO2
-rw-r--r--src/args_parser.c1
-rw-r--r--src/main.cpp6
3 files changed, 2 insertions, 7 deletions
diff --git a/TODO b/TODO
index fef3896..29f3db5 100644
--- a/TODO
+++ b/TODO
@@ -278,3 +278,5 @@ Fix constant framerate not working properly on amd/intel because capture framera
It also appears to skip audio frames on nvidia wayland? why? that should be fine, but it causes video stuttering because of audio/video sync.
Add option to pass a fd (from socketpair) to use for rpc. In the rpc have a common header, with protocol version, data type and data in an enum.
+
+Add the option to set audio track name, for example with -a "track-name:blabla|device:default_output|app:firefox" \ No newline at end of file
diff --git a/src/args_parser.c b/src/args_parser.c
index 546d397..7aee396 100644
--- a/src/args_parser.c
+++ b/src/args_parser.c
@@ -229,7 +229,6 @@ static void usage_full() {
printf(" -a Audio device or application to record from (pulse audio device). Can be specified multiple times. Each time this is specified a new audio track is added for the specified audio device or application.\n");
printf(" The audio device can also be \"default_output\" in which case the default output device is used, or \"default_input\" in which case the default input device is used.\n");
printf(" Multiple audio sources can be merged into one audio track by using \"|\" as a separator into one -a argument, for example: -a \"default_output|default_input\".\n");
- printf(" A name can be given to the audio track by prefixing the audio with <name>/, for example \"track name/default_output\" or \"track name/default_output|default_input\".\n");
printf(" The audio name can also be prefixed with \"device:\", for example: -a \"device:default_output\".\n");
printf(" To record audio from an application then prefix the audio name with \"app:\", for example: -a \"app:Brave\". The application name is case-insensitive.\n");
printf(" To record audio from all applications except the provided ones prefix the audio name with \"app-inverse:\", for example: -a \"app-inverse:Brave\".\n");
diff --git a/src/main.cpp b/src/main.cpp
index 0be3768..4bfd94b 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1383,12 +1383,6 @@ static MergedAudioInputs parse_audio_input_arg(const char *str, const AudioDevic
return result;
}
- const char *track_name_sep_ptr = strchr(str, '/');
- if(track_name_sep_ptr) {
- result.track_name.assign(str, track_name_sep_ptr - str);
- str = track_name_sep_ptr + 1;
- }
-
split_string(str, '|', [&](const char *sub, size_t size) {
AudioInput audio_input;
audio_input.name.assign(sub, size);