Add -preset and -multipass options for higher quality video encoding on nvidia

1 files changed, 61 insertions, 12 deletions

diff --git a/src/main.cpp b/src/main.cpp
index bf17087..8c53c44 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1027,7 +1027,7 @@ static void video_hardware_set_qp(AVCodecContext *codec_context, VideoQuality vi
     }
 }
 
-static void open_video_hardware(AVCodecContext *codec_context, VideoQuality video_quality, bool very_old_gpu, gsr_gpu_vendor vendor, PixelFormat pixel_format, bool hdr, gsr_color_depth color_depth, BitrateMode bitrate_mode, VideoCodec video_codec, bool low_power) {
+static void open_video_hardware(AVCodecContext *codec_context, VideoQuality video_quality, bool very_old_gpu, gsr_gpu_vendor vendor, PixelFormat pixel_format, bool hdr, gsr_color_depth color_depth, BitrateMode bitrate_mode, VideoCodec video_codec, bool low_power, const char *preset, const char *multipass) {
     (void)very_old_gpu;
     AVDictionary *options = nullptr;
 
@@ -1051,6 +1051,12 @@ static void open_video_hardware(AVCodecContext *codec_context, VideoQuality vide
         // }
         av_dict_set(&options, "tune", "hq", 0);
 
+        if(preset)
+            av_dict_set(&options, "preset", preset, 0);
+
+        if(multipass)
+            av_dict_set(&options, "multipass", multipass, 0);
+
         dict_set_profile(codec_context, vendor, color_depth, &options);
 
         if(codec_context->codec_id == AV_CODEC_ID_H264) {
@@ -1113,7 +1119,7 @@ static void open_video_hardware(AVCodecContext *codec_context, VideoQuality vide
 static void usage_header() {
     const bool inside_flatpak = getenv("FLATPAK_ID") != NULL;
     const char *program_name = inside_flatpak ? "flatpak run --command=gpu-screen-recorder com.dec05eba.gpu_screen_recorder" : "gpu-screen-recorder";
-    printf("usage: %s -w <window_id|monitor|focused|portal|region> [-c <container_format>] [-s WxH] [-region WxH+X+Y] [-f <fps>] [-a <audio_input>] [-q <quality>] [-r <replay_buffer_size_sec>] [-restart-replay-on-save yes|no] [-k h264|hevc|av1|vp8|vp9|hevc_hdr|av1_hdr|hevc_10bit|av1_10bit] [-ac aac|opus|flac] [-ab <bitrate>] [-oc yes|no] [-fm cfr|vfr|content] [-bm auto|qp|vbr|cbr] [-cr limited|full] [-df yes|no] [-sc <script_path>] [-cursor yes|no] [-keyint <value>] [-restore-portal-session yes|no] [-portal-session-token-filepath filepath] [-encoder gpu|cpu] [-o <output_file>] [--list-capture-options [card_path] [vendor]] [--list-audio-devices] [--list-application-audio] [-v yes|no] [-gl-debug yes|no] [--version] [-h|--help]\n", program_name);
+    printf("usage: %s -w <window_id|monitor|focused|portal|region> [-c <container_format>] [-s WxH] [-region WxH+X+Y] [-f <fps>] [-a <audio_input>] [-q <quality>] [-r <replay_buffer_size_sec>] [-restart-replay-on-save yes|no] [-k h264|hevc|av1|vp8|vp9|hevc_hdr|av1_hdr|hevc_10bit|av1_10bit] [-ac aac|opus|flac] [-ab <bitrate>] [-oc yes|no] [-fm cfr|vfr|content] [-bm auto|qp|vbr|cbr] [-cr limited|full] [-preset <preset>] [-multipass disabled|half|full] [-df yes|no] [-sc <script_path>] [-cursor yes|no] [-keyint <value>] [-restore-portal-session yes|no] [-portal-session-token-filepath filepath] [-encoder gpu|cpu] [-o <output_file>] [--list-capture-options [card_path] [vendor]] [--list-audio-devices] [--list-application-audio] [-v yes|no] [-gl-debug yes|no] [--version] [-h|--help]\n", program_name);
     fflush(stdout);
 }
 
@@ -1218,6 +1224,14 @@ static void usage_full() {
     printf("        Note that some buggy video players (such as vlc) are unable to correctly display videos in full color range and when upload the video to websites the website\n");
     printf("        might re-encoder the video to make the video limited color range.\n");
     printf("\n");
+    printf("  -preset\n");
+    printf("        Set the video encoding preset. Nvidia only option. Should either be 'p1', 'p2', 'p3', 'p4', 'p5', 'p6' or 'p7'. Higher value give higher quality but slower encoding speed.\n");
+    printf("        Changing this value from the default value may cause driver issues depending on your GPU and driver version. Optional, set to 'p4' by default.\n");
+    printf("\n");
+    printf("  -multipass\n");
+    printf("        Set multipass encoding video encoding option. Nvidia only option. Should either be 'disabled', 'half' or 'full'.\n");
+    printf("        'half' and 'full' give higher quality but slower encoding speed. Optional, set to 'disabled' by default.\n");
+    printf("\n");
     printf("  -df   Organise replays in folders based on the current date.\n");
     printf("\n");
     printf("  -sc   Run a script on the saved video file (asynchronously). The first argument to the script is the filepath to the saved video file and the second argument is the recording type (either \"regular\" or \"replay\").\n");
@@ -3245,6 +3259,17 @@ static AudioDeviceData create_application_audio_audio_input(const MergedAudioInp
 }
 #endif
 
+static bool validate_preset(const char *preset) {
+    if(strlen(preset) != 2)
+        return false;
+
+    for(int i = 1; i <= 7; ++i) {
+        if(preset[0] == 'p' && preset[1] == '0' + i)
+            return true;
+    }
+    return false;
+}
+
 static bool get_image_format_from_filename(const char *filename, gsr_image_format *image_format) {
     if(string_ends_with(filename, ".jpg") || string_ends_with(filename, ".jpeg")) {
         *image_format = GSR_IMAGE_FORMAT_JPEG;
@@ -3374,6 +3399,8 @@ int main(int argc, char **argv) {
         { "-df",                            Arg { {},  is_optional,  !is_list,  ArgType::BOOLEAN, {false} } },
         { "-sc",                            Arg { {},  is_optional,  !is_list,  ArgType::STRING,  {false} } },
         { "-cr",                            Arg { {},  is_optional,  !is_list,  ArgType::STRING,  {false} } },
+        { "-preset",                        Arg { {},  is_optional,  !is_list,  ArgType::STRING,  {false} } },
+        { "-multipass",                     Arg { {},  is_optional,  !is_list,  ArgType::STRING,  {false} } },
         { "-cursor",                        Arg { {},  is_optional,  !is_list,  ArgType::BOOLEAN, {false} } },
         { "-keyint",                        Arg { {},  is_optional,  !is_list,  ArgType::STRING,  {false} } },
         { "-restore-portal-session",        Arg { {},  is_optional,  !is_list,  ArgType::BOOLEAN, {false} } },
@@ -3449,7 +3476,7 @@ int main(int argc, char **argv) {
     //} else if(strcmp(video_codec_to_use, "hevc_vulkan") == 0) {
     //    video_codec = VideoCodec::HEVC_VULKAN;
     } else if(strcmp(video_codec_to_use, "auto") != 0) {
-        fprintf(stderr, "Error: -k should either be either 'auto', 'h264', 'hevc', 'av1', 'vp8', 'vp9', 'hevc_hdr', 'av1_hdr', 'hevc_10bit' or 'av1_10bit', got: '%s'\n", video_codec_to_use);
+        fprintf(stderr, "Error: -k should either be 'auto', 'h264', 'hevc', 'av1', 'vp8', 'vp9', 'hevc_hdr', 'av1_hdr', 'hevc_10bit' or 'av1_10bit', got: '%s'\n", video_codec_to_use);
         usage();
     }
 
@@ -3465,7 +3492,7 @@ int main(int argc, char **argv) {
     } else if(strcmp(audio_codec_to_use, "flac") == 0) {
         audio_codec = AudioCodec::FLAC;
     } else {
-        fprintf(stderr, "Error: -ac should either be either 'aac', 'opus' or 'flac', got: '%s'\n", audio_codec_to_use);
+        fprintf(stderr, "Error: -ac should either be 'aac', 'opus' or 'flac', got: '%s'\n", audio_codec_to_use);
         usage();
     }
 
@@ -3564,7 +3591,7 @@ int main(int argc, char **argv) {
     } else if(strcmp(pixfmt, "yuv444") == 0) {
         pixel_format = PixelFormat::YUV444;
     } else {
-        fprintf(stderr, "Error: -pixfmt should either be either 'yuv420', or 'yuv444', got: '%s'\n", pixfmt);
+        fprintf(stderr, "Error: -pixfmt should either be 'yuv420', or 'yuv444', got: '%s'\n", pixfmt);
         usage();
     }
 
@@ -3736,7 +3763,7 @@ int main(int argc, char **argv) {
     } else if(strcmp(framerate_mode_str, "content") == 0) {
         framerate_mode = FramerateMode::CONTENT;
     } else {
-        fprintf(stderr, "Error: -fm should either be either 'cfr', 'vfr' or 'content', got: '%s'\n", framerate_mode_str);
+        fprintf(stderr, "Error: -fm should either be 'cfr', 'vfr' or 'content', got: '%s'\n", framerate_mode_str);
         usage();
     }
 
@@ -3757,7 +3784,7 @@ int main(int argc, char **argv) {
     } else if(strcmp(bitrate_mode_str, "cbr") == 0) {
         bitrate_mode = BitrateMode::CBR;
     } else if(strcmp(bitrate_mode_str, "auto") != 0) {
-        fprintf(stderr, "Error: -bm should either be either 'auto', 'qp', 'vbr' or 'cbr', got: '%s'\n", bitrate_mode_str);
+        fprintf(stderr, "Error: -bm should either be 'auto', 'qp', 'vbr' or 'cbr', got: '%s'\n", bitrate_mode_str);
         usage();
     }
 
@@ -3810,7 +3837,7 @@ int main(int argc, char **argv) {
         } else if(strcmp(quality_str, "ultra") == 0) {
             quality = VideoQuality::ULTRA;
         } else {
-            fprintf(stderr, "Error: -q should either be either 'medium', 'high', 'very_high' or 'ultra', got: '%s'\n", quality_str);
+            fprintf(stderr, "Error: -q should either be 'medium', 'high', 'very_high' or 'ultra', got: '%s'\n", quality_str);
             usage();
         }
     }
@@ -3825,10 +3852,32 @@ int main(int argc, char **argv) {
     } else if(strcmp(color_range_str, "full") == 0) {
         color_range = GSR_COLOR_RANGE_FULL;
     } else {
-        fprintf(stderr, "Error: -cr should either be either 'limited' or 'full', got: '%s'\n", color_range_str);
+        fprintf(stderr, "Error: -cr should either be 'limited' or 'full', got: '%s'\n", color_range_str);
         usage();
     }
 
+    const char *preset_str = args["-preset"].value();
+    if(preset_str) {
+        if(!validate_preset(preset_str)) {
+            fprintf(stderr, "Error: -preset should either be 'p0', 'p1', 'p2', 'p3', 'p4', 'p5', 'p6' or 'p7', got: '%s'\n", preset_str);
+            usage();
+        }
+    }
+
+    const char *multipass_str = args["-multipass"].value();
+    if(multipass_str) {
+        if(strcmp(multipass_str, "disabled") == 0) {
+            multipass_str = nullptr;
+        } else if(strcmp(multipass_str, "half") == 0) {
+            multipass_str = "qres";
+        } else if(strcmp(multipass_str, "full") == 0) {
+            multipass_str = "fullres";
+        } else {
+            fprintf(stderr, "Error: -multipass should either be 'disabled', 'half' or 'full', got: '%s'\n", multipass_str);
+            usage();
+        }
+    }
+
     const char *output_resolution_str = args["-s"].value();
     if(!output_resolution_str && strcmp(window_str.c_str(), "focused") == 0) {
         fprintf(stderr, "Error: option -s is required when using '-w focused' option\n");
@@ -3843,7 +3892,7 @@ int main(int argc, char **argv) {
         }
 
         if(output_resolution.x < 0 || output_resolution.y < 0) {
-            fprintf(stderr, "Error: invalud value for option -s '%s', expected width and height to be greater or equal to 0\n", output_resolution_str);
+            fprintf(stderr, "Error: invalid value for option -s '%s', expected width and height to be greater or equal to 0\n", output_resolution_str);
             usage();
         }
     }
@@ -3863,7 +3912,7 @@ int main(int argc, char **argv) {
         }
 
         if(region_size.x < 0 || region_size.y < 0 || region_position.x < 0 || region_position.y < 0) {
-            fprintf(stderr, "Error: invalud value for option -region '%s', expected width, height, x and y to be greater or equal to 0\n", region_str);
+            fprintf(stderr, "Error: invalid value for option -region '%s', expected width, height, x and y to be greater or equal to 0\n", region_str);
             usage();
         }
     } else {
@@ -4054,7 +4103,7 @@ int main(int argc, char **argv) {
     if(use_software_video_encoder) {
         open_video_software(video_codec_context, quality, pixel_format, hdr, color_depth, bitrate_mode);
     } else {
-        open_video_hardware(video_codec_context, quality, very_old_gpu, egl.gpu_info.vendor, pixel_format, hdr, color_depth, bitrate_mode, video_codec, low_power);
+        open_video_hardware(video_codec_context, quality, very_old_gpu, egl.gpu_info.vendor, pixel_format, hdr, color_depth, bitrate_mode, video_codec, low_power, preset_str, multipass_str);
     }
     if(video_stream)
         avcodec_parameters_from_context(video_stream->codecpar, video_codec_context);